Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to reduce degree of nesting #431

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Refactor to reduce degree of nesting #431

merged 3 commits into from
Dec 22, 2023

Conversation

mbuechse
Copy link
Contributor

No description provided.

@mbuechse mbuechse requested review from fkr and garloff December 20, 2023 09:27
garloff
garloff approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.
With the one improvement I suggested.
I would prefer it to me merged after after #413 though to avoid merge conflicts.

@garloff garloff merged commit e56929a into main Dec 22, 2023
4 checks passed
@garloff garloff deleted the slight_amendment branch December 22, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garloff garloff garloff approved these changes

@fkr fkr Awaiting requested review from fkr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbuechse @garloff