Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests build #228

Merged
merged 3 commits into from
Mar 21, 2025
Merged

Fix the tests build #228

merged 3 commits into from
Mar 21, 2025

Conversation

vkutuev
Copy link
Contributor

@vkutuev vkutuev commented Mar 20, 2025

Short description

Building project using build.py failed with

tests/test_opencl_merge.cpp:470:14: error: ‘sort’ is not a member of ‘std’
tests/test_vector.cpp:430:14: error: ‘sort’ is not a member of ‘std’

Also, there are many warnings with comparison of integers of different signs in

List of changes

  • Added inclusion of the algorithm header in the corresponding files
  • Change index type in cycles in tests/test_vector.cpp
  • Fix imports in tests/test_opencl_merge.cpp

Type of changes

  • bug-fix (change which fixes some issue)
  • new-feature (change which proposes new feature or functionality)
  • breaking-change (change which brakes compatibility of api or etc.)

Changes aspect

  • unit-tests for C/C++ code added
  • benchmark for C/C++ code added
  • workflow tests to .github scripts added
  • C bindings to C++ code added
  • Python bindings to C code added
  • documentation to C/C++ code added
  • documentation to Python code added

@vkutuev vkutuev requested review from gsvgit and EgorOrachyov March 20, 2025 10:32
@vkutuev vkutuev self-assigned this Mar 20, 2025
@vkutuev vkutuev merged commit 61c94cb into main Mar 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants