Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include end row in LimitFilter #4278

Open
wants to merge 2 commits into
base: 3.1
Choose a base branch
from

Conversation

jivanf
Copy link
Contributor

@jivanf jivanf commented Mar 3, 2025

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change?

This is a fixup for #4217. That PR fixed the original issue by including the end row, but at the same time excluded the heading row, which caused #4271.

This PR modifies LimitFilter to include both the heading row and the end row, as suggested here. The tests were also updated to ensure the headings are imported correctly.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

No.

3️⃣ Does it include tests, if possible?

Yes.

4️⃣ Any drawbacks? Possible breaking changes?

Same drawbacks as #4217.

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.

6️⃣ Thanks for contributing! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant