Skip to content

Disable Timer on World Change#75

Open
nivcoo wants to merge 7 commits into
Spazzinq:betafrom
nivcoo:patch-3
Open

Disable Timer on World Change#75
nivcoo wants to merge 7 commits into
Spazzinq:betafrom
nivcoo:patch-3

Conversation

@nivcoo

@nivcoo nivcoo commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

Hi of course you can test, the concern was that the time continued when we were in a world without fly and being on the ground.
It is therefore necessary when people can not fly deactivate the fly and pause the timer.

@Spazzinq Spazzinq changed the title FIX fly on world change Disable Timer on World Change Mar 15, 2021
@Spazzinq

Copy link
Copy Markdown
Owner

This commit didn't change anything and added a few lines of code, so I just reverted it.

@nivcoo

nivcoo commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

He add world change event....

@nivcoo

nivcoo commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

It's my mainly change in this pull request

@nivcoo

nivcoo commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

Player world in the teleport event is the previous world so we have an issue with that

@nivcoo

nivcoo commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

And i've add check to detect if the teleport event is a world change or not to remove the useless check

@Spazzinq

Copy link
Copy Markdown
Owner

He add world change event....
And i've add check to detect if the teleport event is a world change or not to remove the useless check

The teleport event includes if it's a world change. How does it add any functionality/fix anything?

@nivcoo

nivcoo commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

Add debug on p.getWorld() on teleport event and you can look the issue :p

@nivcoo

nivcoo commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

it sends the check to the old world and therefore activates the fly in a world where the fly is deactivated

@nivcoo

nivcoo commented Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

Okay thx i will edit the file to add a function to do that more properly

@nivcoo

nivcoo commented May 15, 2022

Copy link
Copy Markdown
Contributor Author

Hello, some news ? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants