feat: implement notifications module and API endpoints#20
Merged
Conversation
…listener and database integration
Eng-AmanyMohamed
approved these changes
Jun 27, 2026
Eng-AmanyMohamed
left a comment
Eng-AmanyMohamed
left a comment
Contributor
There was a problem hiding this comment.
Good Job, Israa👏🏻
Eng-AmanyMohamed
approved these changes
Jun 28, 2026
Change NotificationService to accept NotificationDetails from the events contract instead of individual parameters. This simplifies the event listener, eliminates manual field mapping, and adds bulk save capability. Also adds safe enum parsing via fromStringOrDefault() in NotificationType.
Joseph-Sameh-0
approved these changes
Jun 28, 2026
Joseph-Sameh-0
left a comment
Joseph-Sameh-0
left a comment
Member
There was a problem hiding this comment.
Great work ya Israa 👏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the complete infrastructure for the in-app notifications system, enabling event-driven updates across the application and providing clean, scalable APIs.
Key Changes
Features
Notifications Infrastructure: Implemented the core architecture for the notifications module, including entities,
NotificationTypeenums, and an event-drivenNotificationListenerto seamlessly capture and store user activities.Refined API Contracts: Upgraded generic Map responses to concrete DTOs (e.g.,
UnreadCountResponse) within the notifications controller.Paginated Responses: Updated notification endpoints to return mapped
Page<NotificationResponse>rather than raw database entities, providing a clean and scalable data structure tailored for infinite scrolling.Testing
Established a dedicated testing environment for the notifications module with an isolated H2 database configuration (
NotificationsTestApplication).