add json validation to tests

[bendichter]

I added some json schema validation to the tests and found a few minor discrepancies in the json schema

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (26a7d33) to head (18a982a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   89.42%   89.46%   +0.04%     
==========================================
  Files          10       11       +1     
  Lines        1891     1899       +8     
==========================================
+ Hits         1691     1699       +8     
  Misses        200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bendichter]

Here I just added a line to each of the tests. This works, but there might be a more elegant solution, for example to use parameterized tests. Feel free to refactor for style

[bendichter]

@samuelgarcia , @alejoe91

[bendichter]

I wasn't sure about this name change. Both "name" and "model_name" are present as metadata, and neither required by the probe object. Should we make it required here?

[bendichter]

Do we want the json_schema to map perfectly onto the Probe object, or might it make sense of have them hav slightly different requirements?

[alejoe91]

Thanks @bendichter

I think it makes sense to have model_name and not name as required. name is a custom name that can be defined for a probe (e.g., ProbeA-B-C for Open Ephys system), but definitely not a requirement.

[samuelgarcia]

thanks a lot Ben. I will have a look.

[alejoe91]

Added also tests for Open Ephys and SpikeGadgets, so testing is complete :)