Skip to content

Cosmetic logging messages for SC2 #4242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelgarcia merged 4 commits into from
Dec 4, 2025
Merged

Cosmetic logging messages for SC2 #4242

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5b1372
WIP
yger Nov 17, 2025
94bb109
Merge branch 'SpikeInterface:main' into cosmetic_sc2
yger Dec 2, 2025
834f6e3
Merge branch 'SpikeInterface:main' into cosmetic_sc2
yger Dec 4, 2025
d0bbb66
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/spikeinterface/sorters/internal/spyking_circus2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose):
recording_f = common_reference(recording_f)
else:
if verbose:
print("Skipping preprocessing (whitening only)")
if apply_whitening:
print("Skipping preprocessing (whitening only)")
else:
print("Skipping preprocessing (no whitening)")
recording_f = recording
recording_f.annotate(is_filtered=True)

Expand Down Expand Up @@ -373,10 +376,6 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose):
# this release the peak_svd memmap file
templates = dense_templates.to_sparse(new_sparse_mask)

# To be sure that templates have appropriate ms_before and ms_after, up to rounding
templates.ms_before = ms_before
templates.ms_after = ms_after

del more_outs

cleaning_kwargs = params.get("cleaning", {}).copy()
Expand Down Expand Up @@ -420,6 +419,10 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose):
merging_params = params["merging"].copy()
merging_params["debug_folder"] = sorter_output_folder / "merging"

# To be sure that templates have appropriate ms_before and ms_after, up to rounding
templates.ms_before = ms_before
templates.ms_after = ms_after

if len(merging_params) > 0:
if params["motion_correction"] and motion_folder is not None:
from spikeinterface.preprocessing.motion import load_motion_info
Expand Down