Fix artifact removal padding logic #4245
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actsRecordingSegment Previously artifacts would not be removed if the trigger was before `start_frame` but the blanking carried on beyond. Only tested on `zeros` mode.
chrishalcrow
reviewed
Dec 5, 2025
Co-authored-by: Chris Halcrow <[email protected]>
alejoe91
reviewed
Dec 10, 2025
| if pad is None: | ||
| mask = (self.triggers >= start_frame) & (self.triggers < end_frame) | ||
| else: | ||
| mask = (self.triggers >= start_frame - pad[1]) & (self.triggers < end_frame + pad[0]) |
Member
There was a problem hiding this comment.
Suggested change
| mask = (self.triggers >= start_frame - pad[1]) & (self.triggers < end_frame + pad[0]) | |
| mask = (self.triggers >= start_frame - pad[0]) & (self.triggers < end_frame + pad[1]) |
pad is defined as pad = [int(ms_before * fs / 1000), int(ms_after * fs / 1000)]
Member
Author
There was a problem hiding this comment.
This is wrong (tested it to be sure), this would fails if start_frame>trigger-pad[0] and pad[0]<pad[1].
It has to be this as in Chris' edit:
mask = (self.triggers >= start_frame - pad[1]) & (self.triggers < end_frame + pad[0])
One needs to look back for triggers before start_frame-pad[1] if start_frame is after a trigger time point (otherwise the trigger is just ignored), or ahead by end_frame - pad[0] if start_frame and end_frame areboth before a trigger.
alejoe91
previously requested changes
Dec 10, 2025
chrishalcrow
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
RemoveArtifactsRecordingSegmentPreviously artifacts would not be removed if the trigger was before
start_framebut the blanking carried on beyond. Only tested onzerosmode.