Skip to content

Delete some unused references to channel_slice (deprecated in v0.103.0) #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 2 commits into from
Dec 10, 2025
Merged

Delete some unused references to channel_slice (deprecated in v0.103.0) #4246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f91f693
minor: change deprecated channel_slice to select_channels
ecobost Dec 6, 2025
7882052
delete _channel_slice (used by no previous channel_slice function)
ecobost Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/spikeinterface/core/basesnippets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,18 +201,6 @@ def select_channels(self, channel_ids: list | np.array | tuple) -> "BaseSnippets

return ChannelSliceSnippets(self, channel_ids)

def _channel_slice(self, channel_ids, renamed_channel_ids=None):
from .channelslice import ChannelSliceSnippets
import warnings

warnings.warn(
"Snippets.channel_slice will be removed in version 0.103, use `select_channels` or `rename_channels` instead.",
DeprecationWarning,
stacklevel=2,
)
sub_recording = ChannelSliceSnippets(self, channel_ids, renamed_channel_ids=renamed_channel_ids)
return sub_recording

def _remove_channels(self, remove_channel_ids):
from .channelslice import ChannelSliceSnippets

Expand Down
2 changes: 1 addition & 1 deletion src/spikeinterface/core/channelslice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class ChannelSliceSnippets(BaseSnippets):
"""
Class to slice a Snippets object based on channel_ids.

Do not use this class directly but use `snippets.channel_slice(...)`
Do not use this class directly but use `snippets.select_channels(...)`

"""

Expand Down
2 changes: 1 addition & 1 deletion src/spikeinterface/preprocessing/tests/test_detect_bad_channels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def test_detect_bad_channels_ibl(num_channels):

# Test on randomly sorted channels
rng = np.random.default_rng(seed=None)
recording_scrambled = recording.channel_slice(
recording_scrambled = recording.select_channels(
rng.choice(recording.channel_ids, len(recording.channel_ids), replace=False)
)
bad_channel_ids_scrambled, bad_channel_label_scrambled = detect_bad_channels(
Expand Down
2 changes: 1 addition & 1 deletion src/spikeinterface/sorters/external/tests/test_docker_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def test_combinato(run_kwargs, create_cache_folder):
cache_folder = create_cache_folder
rec = run_kwargs["recording"]
channels = rec.get_channel_ids()[0:1]
rec_one_channel = rec.channel_slice(channels)
rec_one_channel = rec.select_channels(channels)
run_kwargs["recording"] = rec_one_channel
sorting = ss.run_sorter(sorter_name="combinato", folder=cache_folder / "combinato", **run_kwargs)
print(sorting)
Expand Down
2 changes: 1 addition & 1 deletion src/spikeinterface/sorters/external/tests/test_singularity_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def test_combinato(run_kwargs, create_cache_folder):
clean_singularity_cache()
rec = run_kwargs["recording"]
channels = rec.get_channel_ids()[0:1]
rec_one_channel = rec.channel_slice(channels)
rec_one_channel = rec.select_channels(channels)
run_kwargs["recording"] = rec_one_channel
sorting = ss.run_sorter(sorter_name="combinato", folder=cache_folder / "combinato", **run_kwargs)
print(sorting)
Expand Down