Fix rp violations bug #4292
Open
Fix rp violations bug #4292
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishalcrow
added
bug
Member
|
Or this? #4291 |
Collaborator
|
This fix also works for me. |
Member
|
Lets go for this no ? |
Collaborator
|
If the computation can't be run without numba, shouldn't this fail at initialization instead of runtime? |
Member
|
Good point. What we could do is adding a package dependency field in the base metric and filter out metrics whose dependencies are not met. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4290 , ensureing that rp_violations returns a
dictor a named tuple, instead of None.@pauladkisson - could you try this out?