Patch lag similarities #4345
Merged
Patch lag similarities #4345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yger
added
bug
for more information, see https://pre-commit.ci
Member
|
This is OK for me. But we need to handle the backward compatibility because lags are now stor in the data. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
samuelgarcia
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the handling of lags in the template_similarity extension, including while selecting/merging, ...
Plus, this patches an important bug while computing similarities with lags. Currently, we were optimizing too aggressively the loop making use that CC(i,j,t) = CC(j,i,n-t) . But because we were only computing for i < j and for negative lags, the matrix was not correct...
This is not a major bug since the default lag is 0, and not many pipelines were making use of such lags, except spike sorting pipelines