Initial PR for Zoho API Integration - Requesting Feedback on API Code and Deployment Files - #1
Open
parthdande wants to merge 8 commits into
Open
Initial PR for Zoho API Integration - Requesting Feedback on API Code and Deployment Files#1parthdande wants to merge 8 commits into
parthdande wants to merge 8 commits into
Conversation
dileeppython
suggested changes
May 15, 2025
dileeppython
suggested changes
May 20, 2025
| run: | | ||
| vars=("CONNECTION_NAME" "DATABASE_NAME" "DB_PASSWORD" "DB_USER" "GUNICORN_WORKERS" "GUNICORN_BIND" "GUNICORN_WORKER_CLASS" "RATELIMIT_HEADERS_ENABLED" "DEFAULT_RATELIMIT" "CACHE_REDIS_USERNAME" "CACHE_REDIS_PASSWORD" "CACHE_REDIS_HOST" "CACHE_REDIS_PORT") | ||
| for var in "${vars[@]}"; do | ||
| secret_name="DEV_${var}" |
Contributor
There was a problem hiding this comment.
you dont need this logic in dev-deploy.yml file. you can define variables here as "DEV_VARIABLE_NAME"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the Zoho API and includes deployment files.
Needs feedback on ->API-Efficiency ,structure and Deployment Files