Skip to content

Conversation

@alexander-yevsyukov
Copy link
Contributor

This PR updates KspBasedPlugin class so that it configures the dependency between kspKotlin tasks and launchSpineCompiler tasks via mustRunAfter() instead of dependsOn(). The latter proved to be unstable between the builds which has to do with parallelism of task configuration and execution.

Also, the latest KSP Gradle Plugin is now used for the build.

Copilot AI review requested due to automatic review settings October 23, 2025 17:06
@alexander-yevsyukov alexander-yevsyukov self-assigned this Oct 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses task dependency configuration issues in the KSP-based plugins by switching from dependsOn() to mustRunAfter() for kspKotlin and launchSpineCompiler tasks. The change resolves stability problems related to parallel task configuration and execution. Additionally, the PR updates the KSP Gradle Plugin to version 2.2.20-2.0.4 and bumps the project version to 2.0.0-SNAPSHOT.019.

  • Replaced dependsOn() with mustRunAfter() in KspBasedPlugin for task ordering
  • Updated KSP Gradle Plugin from 2.1.21-2.0.1 to 2.2.20-2.0.4
  • Removed explicit task dependencies from build scripts where handled by plugin

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
version.gradle.kts Incremented version to 2.0.0-SNAPSHOT.019
tests/build.gradle.kts Removed afterEvaluate block that configured kspKotlin task dependencies
routing/build.gradle.kts Relocated afterEvaluate block (no logic change)
routing-tests/build.gradle.kts Relocated afterEvaluate block (no logic change)
pom.xml Updated version references and KSP dependency version, reordered auto-service dependency
ksp/src/main/kotlin/io/spine/tools/core/jvm/ksp/gradle/KspBasedPlugin.kt Changed task dependency mechanism from dependsOn to mustRunAfter
gradle.properties Added commented debug flag
dependencies.md Updated generated dependency report with new versions and timestamps
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt Updated dogfoodingVersion and version to 2.0.0-SNAPSHOT.018
buildSrc/src/main/kotlin/io/spine/dependency/build/Ksp.kt Unified dogfoodingVersion to use the same value as version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review October 23, 2025 17:07
@alexander-yevsyukov alexander-yevsyukov merged commit b109fe2 into master Oct 23, 2025
6 of 8 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the fix-ksp-tasks-dependencies branch October 23, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants