- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
Fix KSP tasks dependencies #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses task dependency configuration issues in the KSP-based plugins by switching from dependsOn() to mustRunAfter() for kspKotlin and launchSpineCompiler tasks. The change resolves stability problems related to parallel task configuration and execution. Additionally, the PR updates the KSP Gradle Plugin to version 2.2.20-2.0.4 and bumps the project version to 2.0.0-SNAPSHOT.019.
- Replaced 
dependsOn()withmustRunAfter()inKspBasedPluginfor task ordering - Updated KSP Gradle Plugin from 2.1.21-2.0.1 to 2.2.20-2.0.4
 - Removed explicit task dependencies from build scripts where handled by plugin
 
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description | 
|---|---|
| version.gradle.kts | Incremented version to 2.0.0-SNAPSHOT.019 | 
| tests/build.gradle.kts | Removed afterEvaluate block that configured kspKotlin task dependencies | 
| routing/build.gradle.kts | Relocated afterEvaluate block (no logic change) | 
| routing-tests/build.gradle.kts | Relocated afterEvaluate block (no logic change) | 
| pom.xml | Updated version references and KSP dependency version, reordered auto-service dependency | 
| ksp/src/main/kotlin/io/spine/tools/core/jvm/ksp/gradle/KspBasedPlugin.kt | Changed task dependency mechanism from dependsOn to mustRunAfter | 
| gradle.properties | Added commented debug flag | 
| dependencies.md | Updated generated dependency report with new versions and timestamps | 
| buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt | Updated dogfoodingVersion and version to 2.0.0-SNAPSHOT.018 | 
| buildSrc/src/main/kotlin/io/spine/dependency/build/Ksp.kt | Unified dogfoodingVersion to use the same value as version | 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR updates
KspBasedPluginclass so that it configures the dependency betweenkspKotlintasks andlaunchSpineCompilertasks viamustRunAfter()instead ofdependsOn(). The latter proved to be unstable between the builds which has to do with parallelism of task configuration and execution.Also, the latest KSP Gradle Plugin is now used for the build.