Fix taskbar shorcut update

src/Squirrel/ShellFile.cs

@@ -1053,6 +1053,18 @@ ushort timeOut
                 this.shortcutFile = linkFile;
             }
         }
+
+        /// <summary>
+        /// Indicates whether the target is in the given directory.
+        /// </summary>
+        /// <param name="directory">The directory.</param>
+        /// <returns>true if the target is in the given directory; otherwise, false.</returns>
+        internal bool IsTargetInDirectory(
+            string directory)
+        {
+            return System.IO.Path.GetDirectoryName(Target)
+                .Equals(directory, StringComparison.OrdinalIgnoreCase);
+        }
     }
 
     /// <summary>

src/Squirrel/UpdateManager.ApplyReleases.cs

@@ -451,7 +451,7 @@ void fixPinnedExecutables(SemanticVersion newCurrentVersion, bool removeAll = fa
                     try {
                         if (shortcut == null) continue;
                         if (String.IsNullOrWhiteSpace(shortcut.Target)) continue;
-                        if (!shortcut.Target.StartsWith(rootAppDirectory, StringComparison.OrdinalIgnoreCase)) continue;
+                        if (!shortcut.IsTargetInDirectory(rootAppDirectory)) continue;
 
                         if (removeAll) {
                             Utility.DeleteFileHarder(shortcut.ShortCutFile);

test/ShellLinkTests.cs

@@ -0,0 +1,23 @@
+using Squirrel.Shell;
+using Xunit;
+
+namespace Squirrel.Tests
+{
+    public class ShellLinkTests
+    {
+        [Theory]
+        [InlineData(@"C:\MyApp\MyApp.exe", @"C:\MyApp", true)]
+        [InlineData(@"C:\MyApp\MyApp.exe", @"C:\MyAppTwo", false)]
+        public void IsTargetInDirectoryTest(
+            string target,
+            string directory,
+            bool isTargetInDirectory)
+        {
+            var shellLink = new ShellLink
+            {
+                Target = target
+            };
+            Assert.Equal(isTargetInDirectory, shellLink.IsTargetInDirectory(directory));
+        }
+    }
+}

test/Squirrel.Tests.csproj

@@ -96,6 +96,7 @@
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="ReleaseEntryTests.cs" />
     <Compile Include="ReleasePackageTests.cs" />
+    <Compile Include="ShellLinkTests.cs" />
     <Compile Include="SquirrelAwareExecutableDetectorTests.cs" />
     <Compile Include="TestHelpers\AssertExtensions.cs" />
     <Compile Include="TestHelpers\ExposedClass.cs" />