Skip to content

Conversation

@JiyaAgrawal27
Copy link

📝 Description

  • The issue mentioned that login, signup, watchlist add and remove used alert option.
  • On testing, when I checked on the webiste demo, I found that the alert was technically present in Watchlist, but it was not visible.
  • This PR replaces alert() with react-toastify toast notifications for a modern, non-blocking, and user-friendly experience.
  • Kindly check the changes in your system since I dont have the access to the API Keys to login and check my watchlist.

✅ Changes Made

  • Updated src/components/StockList.jsx to use toast instead of alert().
  • Installed react-toastify dependency.
  • Updated package.json & package-lock.json to include the new dependency.

Fixes #71

@github-actions
Copy link

Thanks for opening this Pull Request! A maintainer will review it shortly. Please make sure you've followed all contribution guidelines.

Join our Discord Community for discussions, questions, and real-time collaboration!

@SrigadaAkshayKumar
Copy link
Owner

@JiyaAgrawal27 could you place a screenshot or a video that how it displays the notifications

@JiyaAgrawal27
Copy link
Author

@SrigadaAkshayKumar I can only add and remove from the watchlist if I login, and I dont have the apikeys to login, can you help me out in this.

@SrigadaAkshayKumar
Copy link
Owner

what api keys you are addressing i am not able to understand your message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Replace browser alerts with professional toast notifications for better UX

2 participants