Skip to content

[FEATURE]: Simplify Footer Structure and Integrate Branding with Copyright Notice #67 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ankitkr104 wants to merge 1 commit into from
Closed

[FEATURE]: Simplify Footer Structure and Integrate Branding with Copyright Notice #67 #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions components/layout/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,22 +81,22 @@ export function Footer({

<div className="w-full relative py-2 md:py-2 px-4 md:px-8">
{/* Main footer content */}
<div className="flex flex-col md:flex-row items-center justify-between gap-4 mb-4">
<div className="flex flex-col md:flex-row items-center justify-between gap-4 py-4">
{/* Logo and branding section */}
<div className="flex flex-col md:flex-row items-center gap-3">
{/* Logo */}
<div className="flex-shrink-0">
{activeLogo}
</div>

{/* Branding text */}
{/* Branding text and copyright */}
<div className="text-center md:text-left">
<p className="text-lg font-bold text-foreground">
<p className="text-lg font-bold text-foreground leading-none mb-1">
The Stable Order
</p>
{/* <p className="text-sm text-muted-foreground">
Decentralized auction platform
</p> */}
<p className="text-xs text-muted-foreground">
© {currentYear} Stability Nexus. All rights reserved.
</p>
Comment on lines +92 to +99

@coderabbitai coderabbitai Bot Mar 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Hardcoded user-visible strings should be externalized for i18n.

The copyright text and branding name are hardcoded. As per coding guidelines, user-visible strings should be externalized to resource files for internationalization support.

Affected strings in this segment:

  • "The Stable Order" (line 95)
  • "© {currentYear} Stability Nexus. All rights reserved." (line 98)

Additionally, "Follow us:" on line 106 has the same issue.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@components/layout/footer.tsx` around lines 92 - 99, Externalize the hardcoded
user-visible strings in the Footer component by replacing inline literals ("The
Stable Order", "© {currentYear} Stability Nexus. All rights reserved.", and
"Follow us:") with keys loaded from your i18n resource (e.g., use
t('footer.brand'), t('footer.copyright', { year: currentYear }) and
t('footer.followUs')). Update the Footer component to import and use your
translation hook/function (e.g., useTranslation or t) and ensure the copyright
uses interpolation for currentYear; add corresponding entries to the locale
resource files.

</div>
</div>

Expand Down Expand Up @@ -132,13 +132,6 @@ export function Footer({
</div>
</div>
</div>

{/* Bottom section - Copyright */}
<div className="pt-3 flex justify-center border-t border-border">
<p className="text-xs text-muted-foreground text-center md:text-left">
© {currentYear} Stability Nexus. All rights reserved.
</p>
</div>
</div>
</footer>
);
Expand Down
Loading