Fix: Apply correct dark mode theme text colors in CTASection#74
Fix: Apply correct dark mode theme text colors in CTASection#74kushbosamiya wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis pull request adds dark mode text color styling to the CTA section by applying Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Please resolve the merge conflicts before review. Your PR will only be reviewed by a maintainer after all conflicts have been resolved. 📺 Watch this video to understand why conflicts occur and how to resolve them: |
kushbosamiya
force-pushed
the
fix/cta-theme-binding
branch
from
dab78e8 to
ba630b9
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/CTASection.tsx`:
- Around line 21-25: The section container in CTASection.tsx still uses the dark
background class (bg-dark-bg) so light mode shows a dark background with black
text; update the section element's class list in the CTASection component to use
bg-landing-bg dark:bg-landing-bg-dark instead of bg-dark-bg so the h2 and p
(font-utsaha text-...) render correctly in both light and dark modes; ensure you
only replace the background class and keep existing layout and dark: prefixed
classes intact.
| <h2 className="mx-auto mt-8 max-w-[90%] px-4 font-utsaha text-2xl tracking-tight text-black md:mt-[72px] md:max-w-[768px] md:px-0 md:text-6xl dark:text-white"> | ||
| By Stability Nexus, For Everyone | ||
| </h2> | ||
|
|
||
| <p className="mt-5 px-4 font-utsaha text-lg text-black md:mt-[24px] md:text-2xl"> | ||
| <p className="mt-5 px-4 font-utsaha text-lg text-black md:mt-[24px] md:text-2xl dark:text-white"> |
There was a problem hiding this comment.
This still leaves the light-theme CTA broken.
dark:text-white only helps in dark mode. The reported regression comes from the section container still defaulting to bg-dark-bg at Line 9, so light mode continues to render a dark background with black text here. Please switch the section to bg-landing-bg dark:bg-landing-bg-dark; otherwise this PR doesn’t actually fix issue #58.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@components/CTASection.tsx` around lines 21 - 25, The section container in
CTASection.tsx still uses the dark background class (bg-dark-bg) so light mode
shows a dark background with black text; update the section element's class list
in the CTASection component to use bg-landing-bg dark:bg-landing-bg-dark instead
of bg-dark-bg so the h2 and p (font-utsaha text-...) render correctly in both
light and dark modes; ensure you only replace the background class and keep
existing layout and dark: prefixed classes intact.
|
issue mentioned is already closed. |
2 participants
Applies
dark:text-whiteutility classes to the heading and description elements in the CTASection to maintain visibility against the dark background.\n\nFixes #58Summary by CodeRabbit