set up Drift database with local data models by 4555jan · Pull Request #48 · StabilityNexus/Zplit

4555jan · 2026-05-24T20:18:07Z

Addressed Issues:

Fixes #47

Screenshots/Recordings:

No UI changes in this PR — this is a database layer setup (Drift table definitions and AppDatabase class). No before/after screenshots applicable.

Additional Notes:

This PR sets up the Drift local database foundation for Zplit. It includes the AppDatabase class and five table definitions: UsersTable, GroupsTable, TransactionsTable, BalancesTable, and WalletDetailsTable. database initialization will be wired up in a follow-up PR.
The generated file app_database.g.dart is a build_runner output and is excluded from this PR.

AI Usage Disclosure:

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Check one of the checkboxes below:

This PR does not contain AI-generated code at all.
This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: TODO

Checklist

My PR addresses a single issue, fixes a single bug or makes a single improvement.
My code follows the project's code style and conventions
If applicable, I have made corresponding changes or additions to the documentation
If applicable, I have made corresponding changes or additions to tests
My changes generate no new warnings or errors
I have joined the Discord server and I will share a link to this PR with the project maintainers there
I have read the Contribution Guidelines
Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

coderabbitai · 2026-05-24T20:18:13Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 48dfb47c-e63a-41a9-a865-02d7aa074e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

4555jan · 2026-05-26T18:01:42Z

@M4dhav is this correct ? or it requires some changes ?

…th upsert functions and removed wallet from the db

4555jan · 2026-05-27T20:08:34Z

@M4dhav i removed the insert functions as from as well i added upsert which basically does the same thing is that ok? and i did other changes as well

Mayank4352

Kindly make the requested changes, also if have any questions or suggestions feel free to comment

Mayank4352 · 2026-06-03T14:00:53Z

+const _uuid = Uuid();
+
+@DriftDatabase(
+  tables: [UsersTable, TransactionsTable, BalancesTable, GroupsTable],


Scope (issue #47) lists 5 tables it's missing WalletDetailsTable

actually i discussed with the mentors and turns out we no longer need that table and i also modified the initial issue template

Mayank4352 · 2026-06-03T14:04:01Z

+  tables: [UsersTable, TransactionsTable, BalancesTable, GroupsTable],
+  daos: [TransactionsDao, GroupsDao, UsersDao, BalancesDao],
+)
+class AppDatabase extends _$AppDatabase {


SQLite doesn't enforce foreign keys by default, so the .references() in transactions and balances are currently non-functional

Mayank4352 · 2026-06-03T14:07:22Z

+class GroupsTable extends Table {
+  TextColumn get id => text().clientDefault(() => _uuid.v4())();
+  TextColumn get name => text()();
+  // storing member public keys as comma separated string


Storing member keys as a comma-separated string bypasses many of the benefits of a relational database. It removes foreign key enforcement (deleted users can leave dangling references)

Mayank4352 · 2026-06-03T14:08:13Z

+  TextColumn get description => text().nullable()();
+
+  @override
+  String get tableName => 'groups_table';


Tiny consistency note: this one is 'groups_table' while the others are users, transactions, balances

Mayank4352 · 2026-06-03T14:56:59Z

+
+const _uuid = Uuid();
+
+class GroupsTable extends Table {


Maintain a reference for transaction table to access the transactions in groups, also using a simple FK here will not be a good approach since one group can have multiple transactions

Mayank4352 · 2026-06-03T16:23:49Z

+    return into(balancesTable).insertOnConflictUpdate(balance);
+  }
+
+  Future<int> deletebalaces(String userPublicKey) {


there is a typo also use lower camel case

Mayank4352 · 2026-06-03T16:24:45Z

+    return query.getSingleOrNull();
+  }
+
+  Future<void> upsert(UsersTableCompanion user) {


use lower camel case

upsert is already in lower camel case could you clarify what you'd like changed here

i think this was marked by mistake

Mayank4352 · 2026-06-03T16:24:53Z

+    return into(usersTable).insertOnConflictUpdate(user);
+  }
+
+  Future<int> deleteuser(String publicKey) {


use lower camel case

Mayank4352 · 2026-06-03T16:29:01Z

+  TextColumn get fromUserPublicKey =>
+      text().references(UsersTable, #publicKey)();
+  TextColumn get toUserPublicKey => text().references(UsersTable, #publicKey)();
+  IntColumn get amount => integer()();


can use int64, keeping large crypto values in mind

DecodeX15 · 2026-06-03T20:22:10Z

@4555jan i have reviewed your pr all things pointed by mayank already, so just fix that and overall it's LGTM

Mayank4352 · 2026-06-05T06:46:16Z

+    return into(groupsTable).insertOnConflictUpdate(group);
+  }
+
+  Future<int> deletegroup(String id) {


use lower camel case

Mayank4352 · 2026-06-05T06:50:03Z

+
+class GroupsTable extends Table {
+  TextColumn get id => text().clientDefault(() => _uuid.v4())();
+  TextColumn get name => text()();


it's still just a string relabeled as set, so no dupe protection ("abc,def,abc" is allowed), no FK integrity (foreign keys can't reach inside a CSV, so the PRAGMA foreign_keys = ON doesn't protect membership), and "which groups is user X in?" are still unindexed and gets false-matches on substrings like (alice matches alice99).

Standard fix is a join table, one row per membership, but you can look for better solution as well

Mayank4352 · 2026-06-05T06:54:46Z

+)
+class AppDatabase extends _$AppDatabase {
+  AppDatabase() : super(_openConnection());
+  AppDatabase.forTesting(QueryExecutor executor) : super(executor);


This can be AppDatabase.forTesting(super.executor); instead of AppDatabase.forTesting(QueryExecutor executor) : super(executor);
it'll raise analyser problem

… changed the db version cause of those changes

4555jan · 2026-06-07T12:13:21Z

@M4dhav please review it does everything seems fine ?

M4dhav

Make sure the generated files go into a separate folder to keep the working directory clean. Check @Mayank4352 's build.yaml in Resonate.

4555jan · 2026-06-12T17:43:01Z

@M4dhav i did requested changes

set up Drift database with local data models

c4e036a

4555jan added the gsoc label May 24, 2026

4555jan requested a review from M4dhav May 25, 2026 20:55

feat: add Drift DAOs for database tables

103bb0a

added foreign key refs and removed insert functions as we can work wi…

5cb6421

…th upsert functions and removed wallet from the db

remove wallet table and dao

2b3be43

Mayank4352 suggested changes Jun 3, 2026

View reviewed changes

4555jan added 2 commits June 4, 2026 10:59

some changes to files

6ecd380

i forgot to mention that its stored as set

f2360ba

Mayank4352 suggested changes Jun 5, 2026

View reviewed changes

4555jan added 3 commits June 5, 2026 16:27

added camel case and use super parameter syntax in AppDatabase

8e4a555

basic tests of daos

646a438

added the currency feild in balances table and transactions table and…

05119f7

… changed the db version cause of those changes

forgot to add default currency field to the user table

e308066

M4dhav assigned 4555jan Jun 8, 2026

M4dhav linked an issue Jun 8, 2026 that may be closed by this pull request

[FEATURE]: -Set up Drift database with local data models #47

Open

2 tasks

M4dhav added the enhancement New feature or request label Jun 8, 2026

add drift generated files

f463fbf

M4dhav requested changes Jun 12, 2026

View reviewed changes

4555jan added 4 commits June 12, 2026 21:56

added build files

27d9708

.g files in a diffirent subfolder

8161cfb

removed from dao folder

423e2a4

removed from g files from cores folder

6c4f888

Uh oh!

Conversation

4555jan commented May 24, 2026

Addressed Issues:

Screenshots/Recordings:

Additional Notes:

AI Usage Disclosure:

Checklist

Uh oh!

coderabbitai Bot commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

4555jan commented May 26, 2026

Uh oh!

4555jan commented May 27, 2026

Uh oh!

Mayank4352 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4555jan Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DecodeX15 commented Jun 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mayank4352 Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4555jan commented Jun 7, 2026

Uh oh!

M4dhav left a comment

Choose a reason for hiding this comment

Uh oh!

4555jan commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented May 24, 2026 •

edited

Loading

4555jan Jun 3, 2026 •

edited

Loading

Mayank4352 Jun 5, 2026 •

edited

Loading