Skip to content

Conversation

minStone-dev
Copy link
Contributor

@minStone-dev minStone-dev commented Jul 11, 2024

๐Ÿ” ์ด PR์„ ํ†ตํ•ด ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

์–ด๋–ค ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ• ๊ฑด์ง€, PR์ด ์—ด๋ฆฌ๊ฒŒ ๋œ ๊ณ„๊ธฐ์™€ ๋ชฉ์ ์„ Reviewer๋“ค์ด ์ดํ•ดํ•  ์ˆ˜ ์žˆ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋ฉ”์ธํŽ˜์ด์ง€์˜ ๋ฏธ์…˜/๋žญํ‚น ๋ฆฌ์ŠคํŠธ ํด๋ฆญ์‹œ ํŽ˜์ด์ง€ ์ด๋™ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

โœจ ์ด PR์—์„œ ํ•ต์‹ฌ์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์€ ๋ฌด์—‡์ธ๊ฐ€์š”?

๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์ฃผ์š”ํ•˜๊ฒŒ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์„ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋ฉ”์ธํŽ˜์ด์ง€์˜ ๋ฏธ์…˜/๋žญํ‚น ๋ฆฌ์ŠคํŠธ ํด๋ฆญ์‹œ ํŽ˜์ด์ง€ ์ด๋™ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
    Screen_recording_20240711_145037.webm

๐Ÿ”– ํ•ต์‹ฌ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ์ด์™ธ์— ์ถ”๊ฐ€์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„์ด ์žˆ๋‚˜์š”?

์—†์œผ๋ฉด "์—†์Œ"์ด๋ผ๊ณ  ๊ธฐ์žฌํ•ด์ฃผ์„ธ์š”.

  • ์—†์Œ

๐Ÿง Review ์‹œ ์ด๋Ÿฐ ๋ถ€๋ถ„์„ ์‹ ๊ฒฝ์จ์„œ ๋ด์ฃผ์‹œ๋ฉด ์ข‹๊ฒ ์–ด์š”

๊ฐœ๋ฐœ ๊ณผ์ •์—์„œ ๋‹ค๋ฅธ ๋ถ„์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•˜๊ฑฐ๋‚˜ ํฌ๋กœ์Šค ์ฒดํฌ๊ฐ€ ํ•„์š”ํ•˜๋‹ค๊ณ  ๋А๊ปด์ง„ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋‚จ๊ฒจ์ฃผ์„ธ์š”.

@minStone-dev minStone-dev linked an issue Jul 11, 2024 that may be closed by this pull request
@minStone-dev minStone-dev merged commit d0a8ca2 into develop Jul 11, 2024
@minStone-dev minStone-dev deleted the feature/97-main-page-list-click-event-handing branch July 11, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

main page list click event handing
3 participants