Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#34) Google OAuth ๊ตฌํ˜„ #115

Merged
merged 94 commits into from
Jul 12, 2024

Conversation

Chaejongin12
Copy link
Contributor

๐Ÿ” ์ด PR์„ ํ†ตํ•ด ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

์–ด๋–ค ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ• ๊ฑด์ง€, PR์ด ์—ด๋ฆฌ๊ฒŒ ๋œ ๊ณ„๊ธฐ์™€ ๋ชฉ์ ์„ Reviewer๋“ค์ด ์ดํ•ดํ•  ์ˆ˜ ์žˆ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

โœจ ์ด PR์—์„œ ํ•ต์‹ฌ์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์€ ๋ฌด์—‡์ธ๊ฐ€์š”?

๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์ฃผ์š”ํ•˜๊ฒŒ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์„ ์ ์–ด์ฃผ์„ธ์š”.

  • ๊ธฐ์กด์˜ LoginActivity -> MainActivity์˜ ๋กœ์ง์ด ์•„๋‹Œ MainActivity๋‚ด์—์„œ StackKnowledgeApp์˜ ์ธ์ž๋กœ Login ์ด๋ฒคํŠธ๋ฅผ ๋ฐ›์•„ ์ฒ˜๋ฆฌํ•˜๋„๋ก ๋ฐ”๊ฟจ์Šต๋‹ˆ๋‹ค.
  • Google API Console์˜ ํŒจํ‚ค์ง€ ๋„ค์ด๋ฐ์„ ๋™๊ธฐํ™” ํ•˜๊ธฐ ์œ„ํ•ด app์˜ ํŒจํ‚ค์ง•์„ com.kdn.stack_knowledge ๋กœ ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ”– ํ•ต์‹ฌ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ์ด์™ธ์— ์ถ”๊ฐ€์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„์ด ์žˆ๋‚˜์š”?

์—†์œผ๋ฉด "์—†์Œ"์ด๋ผ๊ณ  ๊ธฐ์žฌํ•ด์ฃผ์„ธ์š”.

  • ์—†์Œ

๐Ÿง Review ์‹œ ์ด๋Ÿฐ ๋ถ€๋ถ„์„ ์‹ ๊ฒฝ์จ์„œ ๋ด์ฃผ์‹œ๋ฉด ์ข‹๊ฒ ์–ด์š”

๊ฐœ๋ฐœ ๊ณผ์ •์—์„œ ๋‹ค๋ฅธ ๋ถ„์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•˜๊ฑฐ๋‚˜ ํฌ๋กœ์Šค ์ฒดํฌ๊ฐ€ ํ•„์š”ํ•˜๋‹ค๊ณ  ๋Š๊ปด์ง„ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋‚จ๊ฒจ์ฃผ์„ธ์š”.

  • ์ปจ๋ฒค์…˜์ด ๋งž์ง€ ์•Š๋Š” ๋ถ€๋ถ„์ด๋‚˜ ๋ถˆํ•„์š”ํ•œ ๊ณต๋ฐฑ, ๋” ๋‚˜์€ ๋กœ์ง์ด๋‚˜ ๋” ๋‚˜์€ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋ฆฌ๋ทฐ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

@Chaejongin12 Chaejongin12 self-assigned this Jul 11, 2024
@Chaejongin12 Chaejongin12 changed the title Feature/34 function auth ๐Ÿ”€ :: (#34) Google OAuth ๊ตฌํ˜„ Jul 11, 2024
:: conflict fix
Copy link
Contributor

@yeongun130 yeongun130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์–ด์š”๐Ÿ‘

@Chaejongin12 Chaejongin12 merged commit 3331a09 into develop Jul 12, 2024
1 check passed
@Chaejongin12 Chaejongin12 deleted the feature/34_function_auth branch July 12, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants