Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#117) Modify Banner Delay Time #118

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

yeongun130
Copy link
Contributor

๐Ÿ” ์ด PR์„ ํ†ตํ•ด ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

์–ด๋–ค ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ• ๊ฑด์ง€, PR์ด ์—ด๋ฆฌ๊ฒŒ ๋œ ๊ณ„๊ธฐ์™€ ๋ชฉ์ ์„ Reviewer๋“ค์ด ์ดํ•ดํ•  ์ˆ˜ ์žˆ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋ฐฐ๋„ˆ๊ฐ€ ๋„˜์–ด๊ฐ€๋Š” ์ฃผ๊ธฐ๋ฅผ ์ข€ ๋” ๋Š˜๋ ธ์Šต๋‹ˆ๋‹ค.

โœจ ์ด PR์—์„œ ํ•ต์‹ฌ์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์€ ๋ฌด์—‡์ธ๊ฐ€์š”?

๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์ฃผ์š”ํ•˜๊ฒŒ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์„ ์ ์–ด์ฃผ์„ธ์š”.

๐Ÿ”– ํ•ต์‹ฌ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ์ด์™ธ์— ์ถ”๊ฐ€์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„์ด ์žˆ๋‚˜์š”?

์—†์œผ๋ฉด "์—†์Œ"์ด๋ผ๊ณ  ๊ธฐ์žฌํ•ด์ฃผ์„ธ์š”.

  • ์—†์Œ

๐Ÿง Review ์‹œ ์ด๋Ÿฐ ๋ถ€๋ถ„์„ ์‹ ๊ฒฝ์จ์„œ ๋ด์ฃผ์‹œ๋ฉด ์ข‹๊ฒ ์–ด์š”

๊ฐœ๋ฐœ ๊ณผ์ •์—์„œ ๋‹ค๋ฅธ ๋ถ„์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•˜๊ฑฐ๋‚˜ ํฌ๋กœ์Šค ์ฒดํฌ๊ฐ€ ํ•„์š”ํ•˜๋‹ค๊ณ  ๋Š๊ปด์ง„ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋‚จ๊ฒจ์ฃผ์„ธ์š”.

  • ํ˜น์‹œ ๋ฐฐ๋„ˆ ๋„˜์–ด๊ฐ€๋Š” ์ฃผ๊ธฐ๊ฐ€ ์ข€ ๋” ๋Š๋ ธ์œผ๋ฉด ์ข‹๊ฒ ๊ฑฐ๋‚˜ ๋นจ๋ž์œผ๋ฉด ์ข‹๊ฒ ๋‹ค ํ•˜์‹œ๋ฉด ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊ฒจ์ฃผ์„ธ์š”

Copy link
Contributor

@minStone-dev minStone-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฃผํ™๋‹˜ ์ปจํŽŒ ๋ฐ›๊ณ  ๋จธ์ง€ํ•˜๋Š”๊ฒŒ ์ข‹์•„ ๋ณด์ž…๋‹ˆ๋‹ค

@yeongun130 yeongun130 merged commit 22092bb into develop Jul 15, 2024
1 check passed
@yeongun130 yeongun130 deleted the feature/117_modify_banner_time branch July 15, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋ฐฐ๋„ˆ ๋„˜์–ด๊ฐ€๋Š” ์ฃผ๊ธฐ ์ˆ˜์ •
4 participants