Skip to content

๐Ÿ”€ :: (#122) Implementation of Logout #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

yeongun130
Copy link
Contributor

@yeongun130 yeongun130 commented Jul 15, 2024

๐Ÿ” ์ด PR์„ ํ†ตํ•ด ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

์–ด๋–ค ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ• ๊ฑด์ง€, PR์ด ์—ด๋ฆฌ๊ฒŒ ๋œ ๊ณ„๊ธฐ์™€ ๋ชฉ์ ์„ Reviewer๋“ค์ด ์ดํ•ดํ•  ์ˆ˜ ์žˆ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ ๊ตฌํ˜„

โœจ ์ด PR์—์„œ ํ•ต์‹ฌ์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์€ ๋ฌด์—‡์ธ๊ฐ€์š”?

๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์ฃผ์š”ํ•˜๊ฒŒ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์„ ์ ์–ด์ฃผ์„ธ์š”.

๐Ÿ”– ํ•ต์‹ฌ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ์ด์™ธ์— ์ถ”๊ฐ€์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„์ด ์žˆ๋‚˜์š”?

์—†์œผ๋ฉด "์—†์Œ"์ด๋ผ๊ณ  ๊ธฐ์žฌํ•ด์ฃผ์„ธ์š”.

  • ์—†์Œ

๐Ÿง Review ์‹œ ์ด๋Ÿฐ ๋ถ€๋ถ„์„ ์‹ ๊ฒฝ์จ์„œ ๋ด์ฃผ์‹œ๋ฉด ์ข‹๊ฒ ์–ด์š”

๊ฐœ๋ฐœ ๊ณผ์ •์—์„œ ๋‹ค๋ฅธ ๋ถ„์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•˜๊ฑฐ๋‚˜ ํฌ๋กœ์Šค ์ฒดํฌ๊ฐ€ ํ•„์š”ํ•˜๋‹ค๊ณ  ๋А๊ปด์ง„ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋‚จ๊ฒจ์ฃผ์„ธ์š”.

  • ์ž˜๋ชป ๊ตฌํ˜„๋œ ๋ถ€๋ถ„์ด ์žˆ๊ฑฐ๋‚˜ ์ˆ˜์ •ํ•ด์•ผ ๋˜๋Š” ๋ถ€๋ถ„์ด ์žˆ์œผ๋ฉด ๋ง์”€ํ•ด์ฃผ์„ธ์š”

@yeongun130 yeongun130 self-assigned this Jul 15, 2024
@yeongun130 yeongun130 linked an issue Jul 15, 2024 that may be closed by this pull request
Copy link
Contributor

@minStone-dev minStone-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TopLevelDestination๋ฅผ ์‚ฌ์šฉํ•˜๋Š”๊ฒŒ ์ข‹์•„ ๋ณด์ž…๋‹ˆ๋‹ค

Copy link
Contributor

@minStone-dev minStone-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onDeleteBackStack()์„ ์ „๋ถ€ ์ง€์šฐ๊ณ  ๋‹ค๋ฅธ ๋ฐฉ์‹์œผ๋กœ ๋ฐฑ์Šคํƒ ๊ด€๋ฆฌ๋ฅผ ํ•˜๋Š”๊ฒŒ ์ข‹์•„ ๋ณด์ž…๋‹ˆ๋‹ค

Comment on lines 36 to 40
localDataSource.removeAccessToken()
localDataSource.removeRefreshToken()
localDataSource.removeAccessTime()
localDataSource.removeRefreshTime()
localDataSource.removeAuthorityInfo()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with(localDataSource) {
removeAccessToken()
... ๋“ฑ์œผ๋กœ ์ฒ˜๋ฆฌํ•˜๋ฉด ์ข‹์„๋“ฏ ํ•ฉ๋‹ˆ๋‹ค
}

@yeongun130 yeongun130 merged commit 51d6209 into develop Jul 15, 2024
1 check passed
@yeongun130 yeongun130 deleted the feature/122_logout_function_connection branch July 15, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ ์—ฐ๊ฒฐ
2 participants