🔀 :: (#46) Mission Domain Network Setting #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:: checkout전 작업물 커밋
…owledge-android-v2 into feature/#46_mission_domain_network_setting # Conflicts: # core/data/src/main/kotlin/com/stackknowledge/di/RepositoryModule.kt # core/network/src/main/kotlin/com/stackknowledge/di/NetworkModule.kt # core/network/src/main/kotlin/com/stackknowledge/di/RemoteDataSourceModule.kt
…owledge-android-v2 into feature/#46_mission_domain_network_setting # Conflicts: # core/data/src/main/kotlin/com/stackknowledge/di/RepositoryModule.kt # core/network/src/main/kotlin/com/stackknowledge/di/NetworkModule.kt # core/network/src/main/kotlin/com/stackknowledge/di/RemoteDataSourceModule.kt
…rk_setting' into feature/#46_mission_domain_network_setting # Conflicts: # core/network/src/main/kotlin/com/stackknowledge/api/MissionAPI.kt # core/network/src/main/kotlin/com/stackknowledge/dto/request/mission/CreateMissionRequest.kt
…owledge-android-v2 into feature/#46_mission_domain_network_setting # Conflicts: # core/data/src/main/kotlin/com/stackknowledge/di/RepositoryModule.kt # core/network/src/main/kotlin/com/stackknowledge/di/NetworkModule.kt # core/network/src/main/kotlin/com/stackknowledge/di/RemoteDataSourceModule.kt
Closed
core/data/src/main/kotlin/com/stackknowledge/repository/mission/MissionRepository.kt
Outdated
Show resolved
Hide resolved
feature/mission/src/main/java/com/stackkowledge/mission/viewmodel/MissionViewModel.kt
Outdated
Show resolved
Hide resolved
feature/mission/src/main/java/com/stackkowledge/mission/viewmodel/MissionViewModel.kt
Outdated
Show resolved
Hide resolved
feature/mission/src/main/java/com/stackkowledge/mission/viewmodel/util/Event.kt
Outdated
Show resolved
Hide resolved
feature/mission/src/main/java/com/stackkowledge/mission/viewmodel/util/errorHandling.kt
Outdated
Show resolved
Hide resolved
…owledge-android-v2 into feature/#46_mission_domain_network_setting # Conflicts: # core/data/src/main/kotlin/com/stackknowledge/di/RepositoryModule.kt # core/network/src/main/kotlin/com/stackknowledge/di/NetworkModule.kt # core/network/src/main/kotlin/com/stackknowledge/di/RemoteDataSourceModule.kt
|
@singleton이 빠진거 같네요 |
|
레트로핏 객체 생성로직이 빠진것 같네요 |
core/network/src/main/kotlin/com/stackknowledge/di/NetworkModule.kt
Outdated
Show resolved
Hide resolved
|
buildconfig 확익부탁드려요 |
core/data/src/main/kotlin/com/stackknowledge/repository/mission/MissionRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
JuuuuHong
reviewed
Jun 26, 2024
core/model/src/main/kotlin/remote/response/mission/MissionsModel.kt
Outdated
Show resolved
Hide resolved
core/model/src/main/kotlin/remote/response/mission/MissionResponseModel.kt
Outdated
Show resolved
Hide resolved
core/model/src/main/kotlin/remote/response/mission/DetailMissionResponseModel.kt
Outdated
Show resolved
Hide resolved
|
return 값이 Unit이 아닌것도 전부 runCatching으로 처리할건가요? |
minStone-dev
approved these changes
Jun 26, 2024
Chaejongin12
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 이 PR을 통해 해결하려는 문제가 무엇인가요?
✨ 이 PR에서 핵심적으로 변경된 사항은 무엇인가요?
🔖 핵심 변경 사항 이외에 추가적으로 변경된 부분이 있나요?
🧐 Review 시 이런 부분을 신경써서 봐주시면 좋겠어요