testing triggers #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tags to VPC Endpoints - terraform 0.11.x * centralize vpce tag param
…branch (terraform-aws-modules#319) * add missing endpoints from terraform-aws-modules#311 * fix mistakes in endpoint names * added endpoints cloudformation, codepipeline, appmesh, sagemaker (api+runtime), transfer, servicecatalog, storagegateway * fix mistakes in endpoint names * fix mistakes in endpoint names * add endpoint tag to full example * terraform format
* Allowing icmp_type and icmp_code for Network ACL rules. Also allowing from_port and to_port to be unset as would be logical in an ICMP rule. * Adding example Network ACLs to allow pinging from public to private subnets. * Added all subnets to support NACL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.