Skip to content

Fix for SQS Sensor when configured credentials are 'None' #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix for SQS Sensor when configured credentials are 'None' #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d589699
Fix to allow credential values of 'None' to work correctly
May 19, 2021
f7fd35d
Incrementing version # and adding Changelog entry for proposed fix
May 19, 2021
5ecfea3
Spacing looked incorrect after last commit.
May 19, 2021
1eeb736
Removing .lower() as that wasn't actually helping.
May 19, 2021
dc7ed2b
Merge branch 'master' into master
kylestewart May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 2.0.2
- Fix issue when configured value for aws_access_key_id is `None` in SQS Sensor.

## 2.0.1
- Deleted duplicate `headers` parameter in `actions/apigateway_test_invoke_authorizer.yaml` and
`actions/apigateway_test_invoke_method.yaml`
Expand Down
5 changes: 4 additions & 1 deletion sensors/sqs_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,10 @@ def _is_same_credentials(session, account_id):

def _setup_session(self):
''' Setup Boto3 session '''
session = Session(aws_access_key_id=self.access_key_id,
if self.access_key_id == "None":
session = Session(aws_access_key_id=None, aws_secret_access_key=None)
else:
session = Session(aws_access_key_id=self.access_key_id,
aws_secret_access_key=self.secret_access_key)

if not self.account_id:
Expand Down