Skip to content

fix script in job-st2canary-for-writable-packs-volume #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix script in job-st2canary-for-writable-packs-volume #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Changelog

## Development
* Fix syntax with ensure-packs-volumes-are-writable job (#403) (by @skiedude)
* Fix syntax with ensure-packs-volumes-are-writable job (#403, #411) (by @skiedude)
* Add securityContext support to custom st2packs images, extra_hooks jobs; Also fallback to st2actionrunner securityContext for misc init container jobs and pods. (#410) (by @cognifloyd)
* Stop generating the DataStore Secret (#385) and checksum labels (#391) when existing secret provided or disabled (by @bmarick)
* Stop generating the checksum labels for Auth Secret (#392) when existing secret provided or disabled (by @bmarick)
Expand Down
5 changes: 3 additions & 2 deletions templates/jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ spec:
# readOnly: false
# ephemeral volumes could also work, ... but that config is even deeper.
command:
- 'sh'
- 'bash'
# -e => exit on failure
# -E => trap ERR is inherited in subfunctions
- '-eEc'
Expand All @@ -545,7 +545,7 @@ spec:
INTRO

function __handle_error__ {
cat <<- 'FAIL'
cat <<- ' FAIL'
ERROR: One or more volumes in st2.packs.volumes (from helm values) does not meet
StackStorm's shared volumes requirements!
see: https://github.com/StackStorm/stackstorm-k8s#method-2-shared-volumes
Expand All @@ -565,6 +565,7 @@ spec:
echo
done
echo DONE

volumeMounts:
{{- include "stackstorm-ha.packs-volume-mounts" $ | nindent 8 }}
{{/* do not include the pack-configs-volume-mount helper here */}}
Expand Down