Skip to content

Option for fast load. Default is true #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

inuex35
Copy link

@inuex35 inuex35 commented Mar 30, 2025

Fast load is enabled for rinex
40 min -> 40 sec
with georinex develop branch

@betaBison
Copy link
Member

@inuex35 can I get some additional context on your desired change?

It looks like in the main branch of georinex, fast already defaults to true? https://github.com/geospace-code/georinex/blob/729b85af584153ac052e81e7652e145c5a5ebb9c/src/georinex/base.py#L29

@inuex35
Copy link
Author

inuex35 commented Apr 6, 2025

Hi this is for rinex ver3, it looks main branch has not supported fast load with version 3 yet.
I left this PR for someone who is looking for fast processing for rinex version 3.
geospace-code/georinex@57b74e0

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (880bbf7) to head (7ee7658).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          27       27           
  Lines        3883     3883           
=======================================
  Hits         3870     3870           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@betaBison
Copy link
Member

Got it, thanks. We'll wait until those changes get filtered up into georinex main and a new version is released on pypi so we can correctly tag it in our dependency requirements. I saw you were making some changes to the georinex repo yourself too. I was able to get code pulled into main by making a pull request and tagging the main maintainer. It just took a very, very, very long time for them to approve it and merge.

Thanks for using glp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants