Skip to content

[Feature] Add compatibility with doris config. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Feature] Add compatibility with doris config. #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/starrocks/connector/spark/sql/conf/StarRocksConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
public interface StarRocksConfig extends Serializable {

String PREFIX = "starrocks.";
String DORIS_PREFIX = "doris."; // to compatible with doris config

Map<String, String> getOriginOptions();

Expand Down
20 changes: 19 additions & 1 deletion src/main/java/com/starrocks/connector/spark/sql/conf/StarRocksConfigBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package com.starrocks.connector.spark.sql.conf;

import com.google.common.collect.ImmutableMap;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -42,6 +43,8 @@ public abstract class StarRocksConfigBase implements StarRocksConfig {

private static final Logger LOG = LoggerFactory.getLogger(StarRocksConfigBase.class);

private static final Map<String, String> TRANSFORM_OPTIONS = ImmutableMap.of();

// reuse some configurations in ConfigurationOptions
public static final String KEY_FE_HTTP = PREFIX + "fe.http.url";
static final String KEY_FE_JDBC = PREFIX + "fe.jdbc.url";
Expand Down Expand Up @@ -79,10 +82,25 @@ public abstract class StarRocksConfigBase implements StarRocksConfig {
private ZoneId timeZone;

public StarRocksConfigBase(Map<String, String> options) {
this.originOptions = new HashMap<>(options);
this.originOptions = compatibleWithDoris(options);
load();
}

private Map<String, String> compatibleWithDoris(Map<String, String> options) {
Map<String, String> properties = new HashMap<>();
for (Map.Entry<String, String> entry : options.entrySet()) {
String key = entry.getKey();
if (key.startsWith(DORIS_PREFIX)) {
key = key.replace(DORIS_PREFIX, PREFIX);
}
if (TRANSFORM_OPTIONS.containsKey(key)) {
key = TRANSFORM_OPTIONS.get(key);
}
properties.put(key, entry.getValue());
}
return properties;
}

private void load() {
this.feHttpUrls = getArray(KEY_FE_HTTP, new String[0]);
this.feJdbcUrl = get(KEY_FE_JDBC);
Expand Down