[Enhancement] Avoid sample collecting table partitions that have not been updated #55026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-shelby
force-pushed
the
fix_unnecessary_partition_sample
branch
from
ef8305f to
3fc1585
Compare
Seaven
reviewed
Jan 14, 2025
fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsCollectJobFactory.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsCollectJobFactory.java
Outdated
Show resolved
Hide resolved
…been updated Signed-off-by: stephen <[email protected]>
fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsCollectJobFactory.java
Show resolved
Hide resolved
stephen-shelby
force-pushed
the
fix_unnecessary_partition_sample
branch
from
5d6153f to
1b368ca
Compare
Signed-off-by: stephen <[email protected]>
stephen-shelby
force-pushed
the
fix_unnecessary_partition_sample
branch
from
1b368ca to
e579410
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 15 / 15 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Jan 20, 2025
murphyatwork
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
currently, we will background collect all partition's statistics when using sample strategy. this may overwrite full analyzed partition statistics. sample analyze table partition may not be accurate. this may cause table level statistics inaccuracies. so we avoid sample collect partitions that have not been updated. This reduces the precision of full table fitting.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: