Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix BE crash if disk is failed #55042

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Jan 14, 2025

Why I'm doing:

In pr #41893, we add some IO operation to save the dropped tablet state in disk when disk is failed. But
if we save meta for the failure disk save_meta will be fail and BE crash

What I'm doing:

Remove the IO operation if the disk is fail. No IO operation is needed in this case.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@srlch srlch requested a review from a team as a code owner January 14, 2025 02:41
@mergify mergify bot assigned srlch Jan 14, 2025
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/tablet_manager.cpp 2 2 100.00% []

@wyb wyb requested a review from luohaha January 22, 2025 03:12
@wyb wyb merged commit e113331 into StarRocks:main Jan 22, 2025
50 of 52 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 22, 2025
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Jan 22, 2025

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 22, 2025

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 22, 2025

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: srlch <[email protected]>
(cherry picked from commit e113331)
mergify bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: srlch <[email protected]>
(cherry picked from commit e113331)
mergify bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: srlch <[email protected]>
(cherry picked from commit e113331)
@wyb
Copy link
Contributor

wyb commented Jan 22, 2025

https://github.com/Mergifyio backport branch-3.4.0

Copy link
Contributor

mergify bot commented Jan 22, 2025

backport branch-3.4.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: srlch <[email protected]>
(cherry picked from commit e113331)
wanpengfei-git pushed a commit that referenced this pull request Jan 22, 2025
wanpengfei-git pushed a commit that referenced this pull request Jan 22, 2025
wanpengfei-git pushed a commit that referenced this pull request Jan 22, 2025
wanpengfei-git pushed a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants