Skip to content

Conversation

ajmcquilkin
Copy link

Typing for the deepClone function is useful to end users since it removes the need for a redundant type cast. For example:

const newReport = deepClone(currentReport) as IReport; // current typing
const newReport = deepClone<IReport>(currentReport); // explicit typing
const newReport = deepClone(currentReport); // implicit typing

The added generic was given a default any type to maintain backwards compatibility, and the return type was set to be T or null to guarantee the change wouldn't break any repositories using the tsconfig strictNullChecks option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant