Skip to content

Bugfix: missing index parameter in validator function #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix: missing index parameter in validator function #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adea0f8
fix: passing parameter index to validator functions instead of consta…
beam-bence Sep 8, 2022
2822dd2
added @param index to JSDoc
beam-bence Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,15 +177,16 @@ export function getValueByPointer(document: any, pointer: string): any {
* @param validateOperation `false` is without validation, `true` to use default jsonpatch's validation, or you can pass a `validateOperation` callback to be used for validation.
* @param mutateDocument Whether to mutate the original document or clone it before applying
* @param banPrototypeModifications Whether to ban modifications to `__proto__`, defaults to `true`.
* @param index The index of the operation if it is from a patch.
* @return `{newDocument, result}` after the operation
*/
export function applyOperation<T>(document: T, operation: Operation, validateOperation: boolean | Validator<T> = false, mutateDocument: boolean = true, banPrototypeModifications: boolean = true, index: number = 0): OperationResult<T> {
if (validateOperation) {
if (typeof validateOperation == 'function') {
validateOperation(operation, 0, document, operation.path);
validateOperation(operation, index, document, operation.path);
}
else {
validator(operation, 0);
validator(operation, index);
}
}
/* ROOT OPERATIONS */
Expand Down