Skip to content

Added escaping to item group and item name. Also fixed product variat…#201

Open
Pat-ops wants to merge 11 commits intoStarktail:version-15from
Pat-ops:Issue-194-and-Issue-200
Open

Added escaping to item group and item name. Also fixed product variat…#201
Pat-ops wants to merge 11 commits intoStarktail:version-15from
Pat-ops:Issue-194-and-Issue-200

Conversation

@Pat-ops
Copy link
Copy Markdown

@Pat-ops Pat-ops commented Aug 11, 2025

…ion id mapping and added correction algorithm for already mis-assigned parent ids, where variation ids would have been required

Description

This fixes issues 194 (escaping characters in product names and categories) and 200 (regular_price is 0, happening on variations, caused by a wrong id assignment - it assigns the parent id, instead of the variation id)

Type of change

⚪ Bug fix (change which fixes an issue)

Tests

[ ] Unit Tests have been updated or added, as required
[ ] UI Tests have been updated or added, as required

Checklist:

[x] My code follows Naming Guidelines (DocType, Field and Variable naming)
[ ] No Form changes / My code follows the Form Design Guidelines
[ ] My code follows the Coding Standards of this project
[ ] My code follows the Code Security Guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas / No comments necessary
[ ] I have made corresponding additions/changes to the documentation
[x] All business logic and validations are on the server-side / No business logic or validation changes
[ ] No patches are necessary / Migration Patches have been added to the correct subdirectory of /patches and patches.txt have been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant