Added escaping to item group and item name. Also fixed product variat…#201
Open
Pat-ops wants to merge 11 commits intoStarktail:version-15from
Open
Added escaping to item group and item name. Also fixed product variat…#201Pat-ops wants to merge 11 commits intoStarktail:version-15from
Pat-ops wants to merge 11 commits intoStarktail:version-15from
Conversation
…ion id mapping and added correction algorithm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion id mapping and added correction algorithm for already mis-assigned parent ids, where variation ids would have been required
Description
This fixes issues 194 (escaping characters in product names and categories) and 200 (regular_price is 0, happening on variations, caused by a wrong id assignment - it assigns the parent id, instead of the variation id)
Type of change
⚪ Bug fix (change which fixes an issue)
Tests
[ ] Unit Tests have been updated or added, as required
[ ] UI Tests have been updated or added, as required
Checklist:
[x] My code follows Naming Guidelines (DocType, Field and Variable naming)
[ ] No Form changes / My code follows the Form Design Guidelines
[ ] My code follows the Coding Standards of this project
[ ] My code follows the Code Security Guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas / No comments necessary
[ ] I have made corresponding additions/changes to the documentation
[x] All business logic and validations are on the server-side / No business logic or validation changes
[ ] No patches are necessary / Migration Patches have been added to the correct subdirectory of
/patchesandpatches.txthave been updated