Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sas): Add customized error message when adding external contributor #91

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

saffaalvi
Copy link

Resolves StatCan/aaw#1254

@saffaalvi saffaalvi marked this pull request as ready for review July 26, 2022 15:31
@saffaalvi saffaalvi force-pushed the sas-error-message branch from a3b17d9 to d50d48f Compare July 26, 2022 20:18
@saffaalvi saffaalvi requested a review from wg102 July 26, 2022 20:19
Copy link

@wg102 wg102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but i do not like the downgrade. Seems like only currently valid solution.

@chuckbelisle
Copy link

chuckbelisle commented Jul 27, 2022

@saffaalvi please create a new issue for us to revisit why the downgrade was necessary (including all of the details of your findings). This will allow us to hopefully change it back to the latest tag of the image.

@chuckbelisle chuckbelisle merged commit 8de6feb into stc-master Jul 27, 2022
@saffaalvi
Copy link
Author

The issue has been created: StatCan/aaw#1284

@saffaalvi saffaalvi deleted the sas-error-message branch July 27, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Error Message to Manage Contributors UI for SAS
3 participants