feat: fishing rod#255
Draft
tn-lorenz wants to merge 13 commits into
Draft
Conversation
Contributor
Author
|
idk why my rebase "created" the Edit: nvm this is from when I tried implementing projectiles myself, before Purdze did it ✌️💀 |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the fishing rod item and (only) the basics of the fishing hook entity, as we currently lack a few core components neccessary to implement the full fishing hook logic (advancements, for example)
Feel free to review while this PR is still in draft!