remove unused code#278
Open
coco875 wants to merge 11 commits into
Open
Conversation
JunkyDeveloper
approved these changes
Jul 22, 2026
JunkyDeveloper
left a comment
JunkyDeveloper
left a comment
Contributor
There was a problem hiding this comment.
LGTM, good deletion
Contributor
|
fix tests |
Contributor
Author
|
ok test was having a weid error so... it's why there is no commit to fix it |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to 277 but focus on deadcode and duplication, while doing it I found that most of them are because of unfinish system or future api, so I only remove what I found like non essential.
the rest are
rest.patch