-
Notifications
You must be signed in to change notification settings - Fork 11
Spectra #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Spectra #58
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 89.26% 88.92% -0.35%
==========================================
Files 5 5
Lines 1025 1065 +40
==========================================
+ Hits 915 947 +32
- Misses 110 118 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the very least, there should be a test for every new function.
I suggest a test that verifies that the new spectra function from event lists give the exact same result as the corresponding functions that get the times instead.
In practice we should get something like
spectrum_fun(events) .== spectrum_fun(events.time)
end | ||
|
||
# Original functions (kept for backward compatibility) | ||
function avg_pds_from_events(times::AbstractVector{<:Real}, gti::AbstractMatrix{<:Real}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this functions
I have added test cases @matteobachetti :) |
In this PR, I have updated the specra function to match our event list and light curve ones
so now we can do :
Output:

output

Output:

Outputs:

For a complete analysis, you may visit this notebook
tagging @matteobachetti @fjebaker @stefanocovino for reviews