Fixes #116 #128
Merged
Fixes #116 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a new algorithm for `add_constraint_and_split`. The new algorithm should reliably replace invalid split positions with known valid positions that are _close enough_ to the correct split. This seems to lead to good results in practice. Also, the split algorithm is now conceptually simpler and has less surface for hidden bugs. Implements a new proptest for checking for additional issues. The proptest needs to be run manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new algorithm for
add_constraint_and_split.The new algorithm should reliably replace invalid split positions with known valid positions that are close enough to the correct split. This seems to lead to good results in practice.
Also, the split algorithm is now conceptually simpler and has less surface for hidden bugs.
Implements a new proptest for checking for additional issues. The proptest needs to be run manually.