Skip to content

Conversation

@yvind
Copy link
Contributor

@yvind yvind commented Mar 21, 2025

This PR fixes #130 by implementing the suggested changes for alpha and beta.
As well as the suggested change for diff.

The doc string is updated with a note on keeping flatness >= 0.0 and that flatness = 0.5 reproduces the original Sibson C1 interpolant. As well as a refrence to Julia Flötotto's thesis and the equality of flatness=0.0 and Flötotto's I1 interpolant (and it's connection to Sibson C0 interpolant)

@yvind yvind marked this pull request as draft March 21, 2025 10:07
@yvind yvind marked this pull request as ready for review March 21, 2025 10:15
@Stoeoef
Copy link
Owner

Stoeoef commented Mar 21, 2025

Can you also please run cargo run --example interpolation and commit the changed images? This will update the images in the help appropriately.
I have also observed changes to the the barycentric interpolation image for some reason. Feel free to include it or leave as is.

@yvind
Copy link
Contributor Author

yvind commented Mar 22, 2025

Will do! I don't know about the barycentric interpolation as I haven't touched anything outside the interpolate_gradient function

@yvind
Copy link
Contributor Author

yvind commented Mar 22, 2025

I didn't observe any chenges to the barycentric images. Only the interpolation_nn_c1 images changed for me when running the interpolation example.

@yvind
Copy link
Contributor Author

yvind commented May 8, 2025

Hi! Are you willing to merge this or do I need to do something I have missed?

@Stoeoef
Copy link
Owner

Stoeoef commented May 8, 2025

Oh dear, my apologies. I forgot about this.

All fine from my side - please ignore the clippy failure, this can sometimes happen if CI uses a newer version of clippy. Merging in!

@Stoeoef Stoeoef merged commit e98a013 into Stoeoef:master May 8, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small bug in sibson c1 interpolation

2 participants