Skip to content

Conversation

@cantrellb
Copy link
Contributor

A position is allowed to be one of cartesian, cartographicDegrees, cartographicRadians or reference as given by the validator error statement. The validator does not check for reference only, its only checks against "cartesian*" values.

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (ea6b643) to head (83f614e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   99.65%   99.66%           
=======================================
  Files           9        9           
  Lines        1470     1477    +7     
=======================================
+ Hits         1465     1472    +7     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stoops-ML
Copy link
Owner

Thanks for this PR. I've never used reference before, but it seems that you're right.

I'd like this fix to apply to all classes that have a reference property, not just Position and ViewFrom. This includes references to things like rgba from another Color property and not just position.

The other classes are:

  • Color
  • EllipsoidRadii
  • ArcType
  • ShadowMode
  • ClassificationType
  • DistanceDisplayCondition
  • BoxDimensions
  • RectangleCoordinates
  • EyeOffset
  • HeightReference
  • ColorBlendMode
  • CornerType
  • NearFarScalar
  • Orientation
  • Uri, not currently implemented. This class needs some work...

Note that a check is required to ensure that only one of the properties that can define a property is entered. For example, the Position class in this PR ensures that only one of cartesian, cartographicDegrees, cartographicRadians, cartesianVelocity, or reference is entered.

Moreover, let me know if you're planning on submitting more PRs in the near future. If so, I'll wait to release another version.

@Stoops-ML Stoops-ML added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Feb 5, 2025
@Stoops-ML Stoops-ML marked this pull request as draft February 5, 2025 08:04
@Stoops-ML Stoops-ML marked this pull request as ready for review February 11, 2025 15:14
@Stoops-ML Stoops-ML merged commit 7d9c5f5 into Stoops-ML:main Feb 11, 2025
7 checks passed
@Stoops-ML
Copy link
Owner

Merging this branch. Will finish the other properties in another PR

@Stoops-ML Stoops-ML mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants