Skip to content

Conversation

@vishwa2710
Copy link
Contributor

While not explicitly mentioned in the guide
interval is a valid property and works when supplied.

{
    "clock": {
        "interval": "2012-03-15T10:00:00Z/2012-03-16T10:00:00Z",
        "currentTime": "2012-03-15T10:00:00Z",
        "multiplier": 60,
        "range": "LOOP_STOP",
        "step": "SYSTEM_CLOCK_MULTIPLIER"
    }
}

@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (d041f49) to head (165e5a5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files           9        9           
  Lines        1562     1564    +2     
=======================================
+ Hits         1559     1561    +2     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stoops-ML
Copy link
Owner

Again, very correct. Thanks very much for pointing this out!

In commit 9d71419 you've combined the fix with code formatting. This means there's a lot of lines that I need to check although you simply added the interval property under the Clock class.

I'll merge this PR if everything seems fine, but please next time keep your commits small and contained. This greatly reduces my workload.

Are you planning on making other changes to the code? I'd like to know before releasing another patch.

Thanks again for your contribution!!

@vishwa2710
Copy link
Contributor Author

Again, very correct. Thanks very much for pointing this out!

In commit 9d71419 you've combined the fix with code formatting. This means there's a lot of lines that I need to check although you simply added the interval property under the Clock class.

Sorry about that! I didn't realize those snuck in, I'm not yet used to the repo formatting and testing so I'm missing some things, will be more diligent in the future!

I'll merge this PR if everything seems fine, but please next time keep your commits small and contained. This greatly reduces my workload.

Are you planning on making other changes to the code? I'd like to know before releasing another patch.

Thanks again for your contribution!!

I don't have anything planned, just fixing a few things as I see them come up!

@Stoops-ML
Copy link
Owner

Great, I’ll merge this PR then. I’ll probably release a patch in a week or two. Thanks again!

@Stoops-ML Stoops-ML merged commit 95700eb into Stoops-ML:main Jul 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants