Skip to content

Commit

Permalink
feat: add setting for sending crash reports
Browse files Browse the repository at this point in the history
  • Loading branch information
TRtomasz committed Dec 5, 2024
1 parent b66d794 commit 3c62ccb
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 8 deletions.
9 changes: 7 additions & 2 deletions src/runtime/env.rs
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,10 @@ fn migrate_storage_schema_to_v16<E: Env>() -> TryEnvFuture<()> {
"serverInForeground".to_owned(),
serde_json::Value::Bool(false),
);
settings.insert(
"sendCrashReports".to_owned(),
serde_json::Value::Bool(false),
);
E::set_storage(PROFILE_STORAGE_KEY, Some(&profile))
}
_ => E::set_storage::<()>(PROFILE_STORAGE_KEY, None),
Expand Down Expand Up @@ -1191,7 +1195,8 @@ mod test {

let migrated_profile = json!({
"settings": {
"serverInForeground": false
"serverInForeground": false,
"sendCrashReports": false
}
});

Expand All @@ -1214,7 +1219,7 @@ mod test {
&migrated_profile.to_string(),
storage
.get(PROFILE_STORAGE_KEY)
.expect("Should have the serverInForegroundSet set"),
.expect("Should have the profile set"),
"Profile should match"
);
}
Expand Down
6 changes: 4 additions & 2 deletions src/types/profile/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ pub struct Settings {
pub pause_on_minimize: bool,
pub surround_sound: bool,
pub streaming_server_warning_dismissed: Option<DateTime<Utc>>,
pub server_in_foreground: bool
pub server_in_foreground: bool,
pub send_crash_reports: bool,
}

#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
Expand Down Expand Up @@ -78,7 +79,8 @@ impl Default for Settings {
pause_on_minimize: false,
surround_sound: false,
streaming_server_warning_dismissed: None,
server_in_foreground: false
server_in_foreground: false,
send_crash_reports: false,
}
}
}
4 changes: 3 additions & 1 deletion src/unit_tests/serde/default_tokens_ext.rs
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ impl DefaultTokens for Settings {
vec![
Token::Struct {
name: "Settings",
len: 28,
len: 29,
},
Token::Str("interfaceLanguage"),
Token::Str("eng"),
Expand Down Expand Up @@ -437,6 +437,8 @@ impl DefaultTokens for Settings {
Token::None,
Token::Str("serverInForeground"),
Token::Bool(false),
Token::Str("sendCrashReports"),
Token::Bool(false),
Token::StructEnd,
]
}
Expand Down
11 changes: 8 additions & 3 deletions src/unit_tests/serde/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,13 @@ fn settings() {
streaming_server_warning_dismissed: Some(
Utc.with_ymd_and_hms(2021, 1, 1, 0, 0, 0).unwrap(),
),
server_in_foreground: false
server_in_foreground: false,
send_crash_reports: false,
},
&[
Token::Struct {
name: "Settings",
len: 28,
len: 29,
},
Token::Str("interfaceLanguage"),
Token::Str("interface_language"),
Expand Down Expand Up @@ -108,6 +109,8 @@ fn settings() {
Token::Str("2021-01-01T00:00:00Z"),
Token::Str("serverInForeground"),
Token::Bool(false),
Token::Str("sendCrashReports"),
Token::Bool(false),
Token::StructEnd,
],
);
Expand All @@ -120,7 +123,7 @@ fn settings_de() {
&[
Token::Struct {
name: "Settings",
len: 23,
len: 24,
},
Token::Str("interfaceLanguage"),
Token::Str("eng"),
Expand Down Expand Up @@ -179,6 +182,8 @@ fn settings_de() {
Token::None,
Token::Str("serverInForeground"),
Token::Bool(false),
Token::Str("sendCrashReports"),
Token::Bool(false),
Token::StructEnd,
],
);
Expand Down

0 comments on commit 3c62ccb

Please sign in to comment.