fix: Player next_video - skip unreleased episodes #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
force-pushed
the
fix/next-video-future-episode
branch
from
b008e1c to
372a91a
Compare
TheBeastLT
approved these changes
Dec 13, 2023
| if let Some(stream) = stream { | ||
| next_video.streams = vec![stream.clone()]; | ||
| .and_then(|(_, next_video)| { | ||
| match next_video.released { |
There was a problem hiding this comment.
Since this released property is not exactly accurate I'm not entirely sure whether it's a good idea not allow going to the next video based on it. Since I'd say it's best to see whether are are valid stream or not for the user. But don't have a strong opinion 🤷
|
after a discussion with @jaruba we are keeping the old behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574