Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce additional details in Addons' ResourceResponse when deserialization fails
Introduce
serde_path_to_error
which, if addon returns a badly formatted JSON, will result in a clear error where the mistake is locatedNB: On items inside each of the different response types we still skip any item which is not deserializable (e.g. missing a mandatory field)
Refactor APIResult to use tagged enum variant (related to API change https://github.com/Stremio/stremio-api/pull/184,
error
is no longer set if it'snull
)Given a bad response of
{"unknown_variant": {"test": 1}}
When
APIResult
does not match any variant it returns a vary vague error:data did not match any variant of untagged enum APIResult
with this change we now return a much cleaner and well understood error:
unknown variant `unknown_variant`, expected `error` or `result` at line 1 column 18