Skip to content

fix(api): ignore invalid addon manifests when pulling addons #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

fix(api): ignore invalid addon manifests when pulling addons #853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/types/api/response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ use std::collections::HashMap;

use chrono::{serde::ts_milliseconds, DateTime, Utc};
use derive_more::TryInto;
use serde::{Deserialize, Serialize};
use serde::{Deserialize, Deserializer, Serialize};
use serde_json::Value;
use serde_with::{serde_as, DisplayFromStr};
use url::Url;

Expand Down Expand Up @@ -49,10 +50,25 @@ impl<T> From<APIResult<T>> for Result<T, APIError> {
#[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct CollectionResponse {
#[serde(deserialize_with = "deserialize_addons")]
pub addons: Vec<Descriptor>,
pub last_modified: DateTime<Utc>,
}

pub fn deserialize_addons<'de, D>(deserializer: D) -> Result<Vec<Descriptor>, D::Error>
where
D: Deserializer<'de>,
{
let values: Vec<Value> = Deserialize::deserialize(deserializer)?;

let addons: Vec<Descriptor> = values
.into_iter()
.filter_map(|v| serde_json::from_value(v).ok())
.collect();

Ok(addons)
}

#[derive(Serialize, Deserialize)]
pub struct AuthResponse {
#[serde(rename = "authKey")]
Expand Down