Skip to content

Add icon and padding#19

Open
NoAccount1 wants to merge 1 commit intoStrikeless:masterfrom
NoAccount1:master
Open

Add icon and padding#19
NoAccount1 wants to merge 1 commit intoStrikeless:masterfrom
NoAccount1:master

Conversation

@NoAccount1
Copy link
Copy Markdown

Hello, small pull request to add a favicon to the extension.

I also added space padding for userscript metadata. I can remove it if you don't like it

@Strikeless
Copy link
Copy Markdown
Owner

Hey, thanks for the PR, I appreciate the interest.
The icon is nice, but I don't really see what it brings to the table. (Visibility in userscript managers amidst other scripts, not sure if very useful in practice?)

Linking their image as an icon seems like potential grounds for a takedown (I assume it's not valid reasoning but I'm not interested in going through that path), whilst not really providing much value.

I'm not that strongly against nor in favor of the addition. Do you have a reason in mind to add the icon, which would improve user experience?
Cheers (sorry for putting such a simple change through this)

@NoAccount1
Copy link
Copy Markdown
Author

This is honestly mainly about aesthetics
I just like having a list of userscripts with their respective icons while it also helps navigating it.

icon list

If you prefer not adding it, that's fine 😅
I can also provide a base64 encoded image without link to the website if you prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants