chore: Update warp terminal open_local_terminal_in_uri functionality #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+242
to
+246
| action_type = "tab" if _gsettings.get_boolean(GSETTINGS_NEW_TAB) else "window" | ||
| Popen([ | ||
| "xdg-open", | ||
| f'warp://action/new_{action_type}?path={result.path}' | ||
| ]) |
There was a problem hiding this comment.
Suggested change
| action_type = "tab" if _gsettings.get_boolean(GSETTINGS_NEW_TAB) else "window" | |
| Popen([ | |
| "xdg-open", | |
| f'warp://action/new_{action_type}?path={result.path}' | |
| ]) | |
| Popen( # pylint: disable=consider-using-with | |
| ["xdg-open", f"warp://action/new_{"tab" if new_tab else "window"}?path={result.path}"] | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After installing https://github.com/Stunkymonkey/nautilus-open-any-terminal/releases/tag/0.6.0 from .deb file on ubuntu 24.04.1 LTS i set terminal to
warpviadconf-editorand it did not work out of box for nautilus file manager on my setup.To be more specific, it did not work with adding new tabs to the terminal, only new windows opened, despite the setup for
tabsindconf-editor.I had to pull sources & update
open_local_terminal_in_urifunctionality a little.