Conversation
app/src/main/res/values/strings.xml
Outdated
| <string name="about_github">GitHub</string> | ||
| <string name="about_legal">Legal</string> | ||
| <string name="about_license">License</string> | ||
| <string name="about_license_gpl">GNU General Public License v3.0</string> |
There was a problem hiding this comment.
Should this be marked non-translatable?
There was a problem hiding this comment.
Ahh, fair enough. Haven't messed with the donottranslate.xml file yet, I can move that over.
Edit: I guess just mark with translatable="false" ?
There was a problem hiding this comment.
Marked about_github and about_license_gpl as non-translatable. I'm not sure how other apps handle Legal and Privacy Policy (like if it needs to/should stay in English?)
There was a problem hiding this comment.
Looks good, I think that is enough, my understanding is only brand or specific names should not be translated.
There was a problem hiding this comment.
I feel like this page could be simplified by creating a helper function for each category. Might be better?
Stypox
force-pushed
the
add-about-page
branch
from
0226730 to
81fef7e
Compare
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you for the idea! I did not like the original layout very much so I ended up overhauling it 😅. I hope that is fine!
Btw, ShareUtils.copyToClipboard already handles showing a toast to the user, but only on older Android versions where the Android system did not already show one.
3 participants
Added a basic About page to the app. Privacy policy section is just a copy-paste of PRIVACY.md. Not sure how that should be handled going forward but the basic framework setup.
Resolves #24, #281