Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support protobuf serializer for custom types #523

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support protobuf serializer for custom types #523

wants to merge 7 commits into from

Conversation

tornac1234
Copy link

Changes made in this pull request

  • Add the possibility to serialize our own types through the protobuf serializer
  • Replace ProtobufSerializerPrecompiled.Serialize and ProtobufSerializerPrecompiled.Deserialize methods which used a big if-tree to have a dictionary lookup instead

As I don't own BZ, someone else will need to adapt this code for it.

@tornac1234 tornac1234 changed the title feat: Support protobuf serializer for custom types Support protobuf serializer for custom types Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tornac1234
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@tornac1234
Copy link
Author

recheck

github-actions bot added a commit that referenced this pull request Jan 2, 2024
@github-actions
@tornac1234 has signed the CLA in #523
21c42bc
Metious
Metious requested changes Jan 7, 2024
View reviewed changes
Copy link
Member

@Metious Metious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks pretty good. Though I believe we should try to make the serializing callbacks auto-generated since they shouldn't contain any custom code.

This is a very nice implementation. Nicely done

Nautilus/Patchers/ProtobufSerializerPrecompiledPatcher.cs Outdated Show resolved Hide resolved
@tornac1234 tornac1234 force-pushed the protobuf-serializer-support branch from b56f030 to 0b97c7d Compare February 28, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Metious Metious Metious requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tornac1234 @Metious @LeeTwentyThree