Add async support for video generation process ✨#8916
Closed
ivandrofly wants to merge 2 commits intoSubtitleEdit:mainfrom
Closed
Add async support for video generation process ✨#8916ivandrofly wants to merge 2 commits intoSubtitleEdit:mainfrom
ivandrofly wants to merge 2 commits intoSubtitleEdit:mainfrom
Conversation
Modified the buttonGenerate_Click and RunEmbedding methods to support asynchronous operations. This change ensures the application remains responsive during lengthy video processing tasks, improving user experience by leveraging async/await and background tasks. Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
Clarified comment in the video generation process to correctly convey the frequency of standby prevention, ensuring it happens every 30 seconds rather than after 30 seconds. This improves code readability and helps future maintenance. Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
ivandrofly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the buttonGenerate_Click and RunEmbedding methods to support asynchronous operations. This change ensures the application remains responsive during lengthy video processing tasks, improving user experience by leveraging async/await and background tasks.